Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/setup/components/SetupView.tsx:45-46
`isEnricherDone` is `true` whenever the enricher is not actively running — including the `"idle"` state before it starts. If a user has persisted enricher tasks from a previous session and returns to the onboarding view before the enricher fires, `QuickWinsColumn` briefly renders with `isDone={true}` (showing "Ready"), then flips to `isDone={false}` ("Checking your PostHog setup…") once `startEnrichment()` is called. The fix requires exposing `enricherStatus` (or a dedicated `isEnricherDone`) from `useSetupRun` so the check can be `enricherStatus === "done" || enricherStatus === "error"` rather than simply `!isEnricherRunning`.
```suggestion
const showQuickWins = enricherTasks.length > 0 || isEnricherRunning;
const isEnricherDone = !isEnricherRunning && enricherStatus !== "idle";
```
Reviews (1): Last reviewed commit: "feat(code): clean up onboarindg UX" | Re-trigger Greptile |
| const showQuickWins = enricherTasks.length > 0 || isEnricherRunning; | ||
| const isEnricherDone = !isEnricherRunning; |
There was a problem hiding this comment.
isEnricherDone is true whenever the enricher is not actively running — including the "idle" state before it starts. If a user has persisted enricher tasks from a previous session and returns to the onboarding view before the enricher fires, QuickWinsColumn briefly renders with isDone={true} (showing "Ready"), then flips to isDone={false} ("Checking your PostHog setup…") once startEnrichment() is called. The fix requires exposing enricherStatus (or a dedicated isEnricherDone) from useSetupRun so the check can be enricherStatus === "done" || enricherStatus === "error" rather than simply !isEnricherRunning.
| const showQuickWins = enricherTasks.length > 0 || isEnricherRunning; | |
| const isEnricherDone = !isEnricherRunning; | |
| const showQuickWins = enricherTasks.length > 0 || isEnricherRunning; | |
| const isEnricherDone = !isEnricherRunning && enricherStatus !== "idle"; |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/setup/components/SetupView.tsx
Line: 45-46
Comment:
`isEnricherDone` is `true` whenever the enricher is not actively running — including the `"idle"` state before it starts. If a user has persisted enricher tasks from a previous session and returns to the onboarding view before the enricher fires, `QuickWinsColumn` briefly renders with `isDone={true}` (showing "Ready"), then flips to `isDone={false}` ("Checking your PostHog setup…") once `startEnrichment()` is called. The fix requires exposing `enricherStatus` (or a dedicated `isEnricherDone`) from `useSetupRun` so the check can be `enricherStatus === "done" || enricherStatus === "error"` rather than simply `!isEnricherRunning`.
```suggestion
const showQuickWins = enricherTasks.length > 0 || isEnricherRunning;
const isEnricherDone = !isEnricherRunning && enricherStatus !== "idle";
```
How can I resolve this? If you propose a fix, please make it concise.|
@charlesvien tyyyy can i get a stamp downstream too pls 🙏 |
34ec901 to
f6c3780
Compare

Problem
onboarding UX is a little unintuitive
Changes
How did you test this?
manually
Publish to changelog?
no