Skip to content

feat(code): clean up onboarding UX#2096

Merged
adboio merged 1 commit intomainfrom
05-07-feat_code_clean_up_onboarindg_ux
May 7, 2026
Merged

feat(code): clean up onboarding UX#2096
adboio merged 1 commit intomainfrom
05-07-feat_code_clean_up_onboarindg_ux

Conversation

@adboio
Copy link
Copy Markdown
Contributor

@adboio adboio commented May 7, 2026

Problem

onboarding UX is a little unintuitive

Changes

  • puts "quick tasks" and discovery run in two columns side by side
  • makes the skip button more prominent
Screenshot 2026-05-07 at 1.39.00 PM.png
Screenshot 2026-05-07 at 1.39.07 PM.png

How did you test this?

manually

Publish to changelog?

no

Copy link
Copy Markdown
Contributor Author

adboio commented May 7, 2026

@adboio adboio mentioned this pull request May 7, 2026
@adboio adboio changed the title feat(code): clean up onboarindg UX feat(code): clean up onboarding UX May 7, 2026
@adboio adboio requested a review from a team May 7, 2026 20:23
@adboio adboio marked this pull request as ready for review May 7, 2026 20:23
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 7, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/code/src/renderer/features/setup/components/SetupView.tsx:45-46
`isEnricherDone` is `true` whenever the enricher is not actively running — including the `"idle"` state before it starts. If a user has persisted enricher tasks from a previous session and returns to the onboarding view before the enricher fires, `QuickWinsColumn` briefly renders with `isDone={true}` (showing "Ready"), then flips to `isDone={false}` ("Checking your PostHog setup…") once `startEnrichment()` is called. The fix requires exposing `enricherStatus` (or a dedicated `isEnricherDone`) from `useSetupRun` so the check can be `enricherStatus === "done" || enricherStatus === "error"` rather than simply `!isEnricherRunning`.

```suggestion
  const showQuickWins = enricherTasks.length > 0 || isEnricherRunning;
  const isEnricherDone = !isEnricherRunning && enricherStatus !== "idle";
```

Reviews (1): Last reviewed commit: "feat(code): clean up onboarindg UX" | Re-trigger Greptile

Comment on lines +45 to +46
const showQuickWins = enricherTasks.length > 0 || isEnricherRunning;
const isEnricherDone = !isEnricherRunning;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 isEnricherDone is true whenever the enricher is not actively running — including the "idle" state before it starts. If a user has persisted enricher tasks from a previous session and returns to the onboarding view before the enricher fires, QuickWinsColumn briefly renders with isDone={true} (showing "Ready"), then flips to isDone={false} ("Checking your PostHog setup…") once startEnrichment() is called. The fix requires exposing enricherStatus (or a dedicated isEnricherDone) from useSetupRun so the check can be enricherStatus === "done" || enricherStatus === "error" rather than simply !isEnricherRunning.

Suggested change
const showQuickWins = enricherTasks.length > 0 || isEnricherRunning;
const isEnricherDone = !isEnricherRunning;
const showQuickWins = enricherTasks.length > 0 || isEnricherRunning;
const isEnricherDone = !isEnricherRunning && enricherStatus !== "idle";
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/setup/components/SetupView.tsx
Line: 45-46

Comment:
`isEnricherDone` is `true` whenever the enricher is not actively running — including the `"idle"` state before it starts. If a user has persisted enricher tasks from a previous session and returns to the onboarding view before the enricher fires, `QuickWinsColumn` briefly renders with `isDone={true}` (showing "Ready"), then flips to `isDone={false}` ("Checking your PostHog setup…") once `startEnrichment()` is called. The fix requires exposing `enricherStatus` (or a dedicated `isEnricherDone`) from `useSetupRun` so the check can be `enricherStatus === "done" || enricherStatus === "error"` rather than simply `!isEnricherRunning`.

```suggestion
  const showQuickWins = enricherTasks.length > 0 || isEnricherRunning;
  const isEnricherDone = !isEnricherRunning && enricherStatus !== "idle";
```

How can I resolve this? If you propose a fix, please make it concise.

Copy link
Copy Markdown
Member

@charlesvien charlesvien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TYVM

Copy link
Copy Markdown
Contributor Author

adboio commented May 7, 2026

@charlesvien tyyyy can i get a stamp downstream too pls 🙏

@adboio adboio added the Create release This will trigger a new release label May 7, 2026 — with Graphite App
Copy link
Copy Markdown
Contributor Author

adboio commented May 7, 2026

Merge activity

  • May 7, 8:44 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • May 7, 8:45 PM UTC: Graphite rebased this pull request as part of a merge.
  • May 7, 8:54 PM UTC: @adboio merged this pull request with Graphite.

@adboio adboio changed the base branch from 05-04-feat_code_enricher_run to graphite-base/2096 May 7, 2026 20:44
@adboio adboio changed the base branch from graphite-base/2096 to main May 7, 2026 20:45
@adboio adboio force-pushed the 05-07-feat_code_clean_up_onboarindg_ux branch from 34ec901 to f6c3780 Compare May 7, 2026 20:45
@adboio adboio merged commit a455157 into main May 7, 2026
16 checks passed
@adboio adboio deleted the 05-07-feat_code_clean_up_onboarindg_ux branch May 7, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Create release This will trigger a new release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants