feat: Remove signals step to improve conversion#2208
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Prompt To Fix All With AIFix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
apps/code/src/renderer/features/onboarding/components/OnboardingFlow.tsx:46
**Lost prefetch for GitHub integration step**
`usePrefetchSignalData` was also eagerly prefetching `["integrations", projectId]`, `["integrations", "list"]`, and the nested GitHub repositories — data consumed by the still-present `GitIntegrationStep`. Removing the hook means those queries will now be fetched on-demand when the user arrives at the GitHub step, adding a visible loading delay that didn't exist before. Consider either keeping the integrations-only prefetch (renaming the hook to reflect its scope) or adding an equivalent prefetch inside `GitIntegrationStep` itself.
Reviews (1): Last reviewed commit: "Remove signals step to improve conversio..." | Re-trigger Greptile |
| (state) => state.navigateToTaskInput, | ||
| ); | ||
| const logoutMutation = useLogoutMutation(); | ||
| const isAuthenticated = useAuthStateValue( |
There was a problem hiding this comment.
Lost prefetch for GitHub integration step
usePrefetchSignalData was also eagerly prefetching ["integrations", projectId], ["integrations", "list"], and the nested GitHub repositories — data consumed by the still-present GitIntegrationStep. Removing the hook means those queries will now be fetched on-demand when the user arrives at the GitHub step, adding a visible loading delay that didn't exist before. Consider either keeping the integrations-only prefetch (renaming the hook to reflect its scope) or adding an equivalent prefetch inside GitIntegrationStep itself.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/code/src/renderer/features/onboarding/components/OnboardingFlow.tsx
Line: 46
Comment:
**Lost prefetch for GitHub integration step**
`usePrefetchSignalData` was also eagerly prefetching `["integrations", projectId]`, `["integrations", "list"]`, and the nested GitHub repositories — data consumed by the still-present `GitIntegrationStep`. Removing the hook means those queries will now be fetched on-demand when the user arrives at the GitHub step, adding a visible loading delay that didn't exist before. Consider either keeping the integrations-only prefetch (renaming the hook to reflect its scope) or adding an equivalent prefetch inside `GitIntegrationStep` itself.
How can I resolve this? If you propose a fix, please make it concise.061d724 to
e7fd357
Compare
1b824ae to
469d6fb
Compare
e7fd357 to
fcde1a8
Compare
fcde1a8 to
8d57b36
Compare
8d57b36 to
02e2814
Compare

Problem
The signals/inbox setup forces users to configure integrations during onboarding, hurting conversion. The inbox already shows a setup pane on first open, so this step is redundant.
Changes
signalsfrom onboarding step union and arrayinstall-clithe final step; complete onboarding straight to task inputHow did you test this?
Manually
Publish to changelog?