Skip to content

fix(inbox): fix report-header icon buttons#2245

Merged
adboio merged 1 commit into
mainfrom
posthog-code/inbox-report-icon-button-hover
May 22, 2026
Merged

fix(inbox): fix report-header icon buttons#2245
adboio merged 1 commit into
mainfrom
posthog-code/inbox-report-icon-button-hover

Conversation

@joshsny
Copy link
Copy Markdown
Contributor

@joshsny joshsny commented May 20, 2026

The copy-link and close icon buttons at the top of the report detail pane shared a rounded p-0.5 class — only 2 px of padding around a 14 px icon, which made the hover background read as a tight rectangle with no perceivable corner radius. Switch both to the standard h-5 w-5 icon-button pattern used elsewhere in the app: a fixed 20×20 hit area, centered icon, and a smoothly transitioning, properly rounded hover background.

Generated-By: PostHog Code
Task-Id: b3534ac5-e998-46a1-b0bb-be29b51c67d1

Problem

Changes

How did you test this?

Publish to changelog?

The copy-link and close icon buttons at the top of the report detail
pane shared a `rounded p-0.5` class — only 2 px of padding around a
14 px icon, which made the hover background read as a tight rectangle
with no perceivable corner radius. Switch both to the standard
`h-5 w-5` icon-button pattern used elsewhere in the app: a fixed
20×20 hit area, centered icon, and a smoothly transitioning, properly
rounded hover background.

Generated-By: PostHog Code
Task-Id: b3534ac5-e998-46a1-b0bb-be29b51c67d1
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 20, 2026

Comments Outside Diff (1)

  1. apps/code/src/renderer/features/inbox/components/detail/ReportDetailPane.tsx, line 401-403 (link)

    P1 The close button wasn't updated — it still has the old rounded p-0.5 pattern that the PR description says was fixed. Only the copy-link button received the new h-5 w-5 items-center justify-center treatment, leaving the close button with the same tight-rectangle hover appearance the PR intends to eliminate.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: apps/code/src/renderer/features/inbox/components/detail/ReportDetailPane.tsx
    Line: 401-403
    
    Comment:
    The close button wasn't updated — it still has the old `rounded p-0.5` pattern that the PR description says was fixed. Only the copy-link button received the new `h-5 w-5 items-center justify-center` treatment, leaving the close button with the same tight-rectangle hover appearance the PR intends to eliminate.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
apps/code/src/renderer/features/inbox/components/detail/ReportDetailPane.tsx:401-403
The close button wasn't updated — it still has the old `rounded p-0.5` pattern that the PR description says was fixed. Only the copy-link button received the new `h-5 w-5 items-center justify-center` treatment, leaving the close button with the same tight-rectangle hover appearance the PR intends to eliminate.

```suggestion
            className="flex h-5 w-5 items-center justify-center rounded text-gray-11 transition-colors hover:bg-gray-3 hover:text-gray-12"
          >
            <XIcon size={14} />
```

Reviews (1): Last reviewed commit: "fix(inbox): give report-header icon butt..." | Re-trigger Greptile

@adboio adboio merged commit beed3a6 into main May 22, 2026
15 checks passed
@adboio adboio deleted the posthog-code/inbox-report-icon-button-hover branch May 22, 2026 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants