Skip to content

chore(devex): Added stamphog to code#2316

Merged
charlesvien merged 3 commits into
mainfrom
tom/stamphog
May 28, 2026
Merged

chore(devex): Added stamphog to code#2316
charlesvien merged 3 commits into
mainfrom
tom/stamphog

Conversation

@Gilbert09
Copy link
Copy Markdown
Member

Changes

  • Added the stamphog PR approval flow to the code repo - the dev of the mobile app will require fast development on an unreleased product, and so this will help a lot

@Gilbert09 Gilbert09 requested a review from a team May 22, 2026 21:16
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 22, 2026

Prompt To Fix All With AI
Fix the following 2 code review issues. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 2
.github/workflows/pr-approval-agent.yml:68-71
**Missing Python scripts — workflow dead on arrival**

`tools/pr-approval-agent/review_pr.py` does not exist anywhere in this repository (verified against both the PR head and the `master` branch). The workflow always checks out `master` before running, so the `uv run` call here will always exit non-zero with "No such file or directory". The same applies to `tools/pr-approval-agent/dismiss_check.py` in the `decide-delta` job (line 187). Both scripts need to be merged to `master` before this workflow will function.

### Issue 2 of 2
.github/workflows/pr-approval-agent.yml:187
**Same missing-script issue in `decide-delta`**

`tools/pr-approval-agent/dismiss_check.py` is also absent from master. Because `decide-delta` has `set -euo pipefail`, the failure here causes the entire `decide-delta` job to fail, which in turn causes the `review` job's `needs.decide-delta.result == 'failure'` branch to fire — running a review job that then also fails for the same reason.

Reviews (1): Last reviewed commit: "Added stamphog to code" | Re-trigger Greptile

Comment thread .github/workflows/pr-approval-agent.yml
Comment thread .github/workflows/pr-approval-agent.yml
@Gilbert09 Gilbert09 removed the request for review from a team May 22, 2026 21:24
@Gilbert09 Gilbert09 added the Stamphog This will request an autostamp by stamphog on small changes label May 22, 2026
@stamphog
Copy link
Copy Markdown

stamphog Bot commented May 28, 2026

Review agent failed — check the workflow run and re-apply the label to retry.

@stamphog stamphog Bot removed the Stamphog This will request an autostamp by stamphog on small changes label May 28, 2026
Gilbert09 added 3 commits May 27, 2026 18:04
Port the PR approval agent (gates, reviewer, dismiss-check, migration-risk)
from PostHog/posthog into tools/pr-approval-agent/ so the existing
pr-approval-agent workflow has the python it needs to run. Adapt for this
repo: main default branch, PostHog/code default --repo.
@charlesvien charlesvien enabled auto-merge (squash) May 28, 2026 01:10
@charlesvien charlesvien merged commit 9ec27c9 into main May 28, 2026
17 checks passed
@charlesvien charlesvien deleted the tom/stamphog branch May 28, 2026 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants