feat(settings): add inbox Slack notifications to Slack settings#2410
Merged
Conversation
The Slack settings view previously only listed connected workspaces. Inbox notification config was hidden inside the inbox "Configure inbox" dialog, which is hard to discover. Embed the existing self-contained SignalSlackNotificationsSettings component below the workspace list so users can manage inbox notification delivery alongside their workspace connections. Generated-By: PostHog Code Task-Id: 775c509f-8512-4b9f-a1f8-9d2bc0f2eefc
andrewm4894
approved these changes
May 28, 2026
Contributor
|
Reviews (1): Last reviewed commit: "feat(settings): add inbox Slack notifica..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Slack settings view previously only listed connected workspaces and a "Manage in PostHog Web" button. Inbox notification configuration (workspace, channel, min priority) lived only inside the inbox "Configure inbox" dialog — discoverable in roughly nobody's experience.
Changes
Embed the existing self-contained
SignalSlackNotificationsSettingscomponent below the workspace list inSlackSettings.tsx. The component already handles loading, no-integration ("Connect Slack workspace" CTA), workspace selection, channel picking, and min-priority selection — so this is a one-import + one-render addition.How did you test this?
pnpm --filter code typecheckpassespnpm exec biome checkon the modified file passesPublish to changelog?
no
Created with PostHog Code