fix: resolve codex-acp binary path on Windows by appending .exe extension#2444
Merged
k11kirky merged 1 commit intoJun 1, 2026
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "fix: resolve codex-acp binary path on Wi..." | Re-trigger Greptile |
Contributor
|
Hey @Basit-Balogun10 - you will need to sign these commits in order for us to merge it, or ill have to recreate the change with a signed commit of my own (which will remove your contribution label) |
2b72838 to
eb387d6
Compare
Contributor
Author
|
Hi @k11kirky |
Contributor
|
@Basit-Balogun10 Thanks, youll need to do that with the other PR's too! |
Contributor
Author
|
Oh yeah, on it already, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Closes #2445
On Windows,
getCodexBinaryPath()looks for the binary at.vite/build/codex-acp/codex-acp— without the.exeextension. The file on disk iscodex-acp.exe, so the lookup always fails and the Codex adapter cannot start.The error thrown is:
This causes the session to fall back to Claude silently, even when the user has explicitly selected a Codex/OpenAI model and the binary is present.
Note: the Claude binary path (line 341) already handles this correctly with a platform check — this fix applies the same pattern to the Codex binary.
Changes
Added a
process.platform === "win32"check togetCodexBinaryPath(), matching the existing pattern ingetClaudeBinaryPath():How did you test this?
Tested manually on Windows 11 (WSL2 dev environment) running the dev build (
pnpm startfrom the worktree):codex-acp.exevianode apps/code/scripts/download-binaries.mjs[CodexAcpAgent] Spawning codex-acp processappears in logs, task runs successfully through OpenAIPublish to changelog?
no