Skip to content

fix: properly clean up processes on every code path#580

Merged
jonathanlab merged 1 commit intomainfrom
01-23-fix_properly_clean_up_processes_on_every_code_path
Jan 27, 2026
Merged

fix: properly clean up processes on every code path#580
jonathanlab merged 1 commit intomainfrom
01-23-fix_properly_clean_up_processes_on_every_code_path

Conversation

@jonathanlab
Copy link
Contributor

When sessions were recreated, e.g. after token refresh, old agent processes were not properly being cleaned up.
This (probably) causes zombie processes such as in #523.

@jonathanlab jonathanlab marked this pull request as ready for review January 23, 2026 12:36
@jonathanlab jonathanlab requested a review from a team as a code owner January 23, 2026 12:36
@jonathanlab jonathanlab force-pushed the 01-23-fix_properly_clean_up_processes_on_every_code_path branch from 650bfff to ad7f10e Compare January 27, 2026 11:39
When sessions were recreated, e.g. after token refresh, old agent processes were not properly being cleaned up.
This (probably) causes zombie processes such as in #523.
@jonathanlab jonathanlab force-pushed the 01-23-fix_properly_clean_up_processes_on_every_code_path branch from ad7f10e to 02e768f Compare January 27, 2026 14:25
Copy link
Contributor Author

jonathanlab commented Jan 27, 2026

Merge activity

  • Jan 27, 2:52 PM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 27, 2:53 PM UTC: @jonathanlab merged this pull request with Graphite.

@jonathanlab jonathanlab merged commit d07fc56 into main Jan 27, 2026
13 checks passed
@jonathanlab jonathanlab deleted the 01-23-fix_properly_clean_up_processes_on_every_code_path branch January 27, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants