Skip to content

fix: Kill all shell pids on quit + migrate legacy shell manager #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanlab merged 4 commits into from
Jan 26, 2026
Merged

fix: Kill all shell pids on quit + migrate legacy shell manager #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
72c0082
Kill all shell pids on quit
charlesvien Jan 25, 2026
f9f901f
Delete shellManager.ts
charlesvien Jan 25, 2026
c54f2d8
Use ShellService instead of the legacy shell manager lib
charlesvien Jan 25, 2026
4208f2e
lint
charlesvien Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
185 changes: 0 additions & 185 deletions apps/twig/src/main/lib/shellManager.ts
View file
Open in desktop

This file was deleted.

10 changes: 10 additions & 0 deletions apps/twig/src/main/services/app-lifecycle/service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { MAIN_TOKENS } from "../../di/tokens.js";
import { logger } from "../../lib/logger.js";
import type { AgentService } from "../agent/service.js";
import { shutdownPostHog, trackAppEvent } from "../posthog-analytics.js";
import type { ShellService } from "../shell/service.js";

const log = logger.scope("app-lifecycle");

Expand All @@ -13,6 +14,9 @@ export class AppLifecycleService {
@inject(MAIN_TOKENS.AgentService)
private agentService!: AgentService;

@inject(MAIN_TOKENS.ShellService)
private shellService!: ShellService;

private _isQuittingForUpdate = false;

get isQuittingForUpdate(): boolean {
Expand All @@ -26,6 +30,12 @@ export class AppLifecycleService {
async shutdown(): Promise<void> {
log.info("Performing graceful shutdown...");

try {
this.shellService.destroyAll();
} catch (error) {
log.error("Error cleaning up ShellService during shutdown", error);
}

try {
await this.agentService.cleanupAll();
} catch (error) {
Expand Down
Loading
Loading