Skip to content

fix: only navigate to settings, dont toggle#714

Merged
charlesvien merged 1 commit intomainfrom
fix/settings-nav-fix
Jan 30, 2026
Merged

fix: only navigate to settings, dont toggle#714
charlesvien merged 1 commit intomainfrom
fix/settings-nav-fix

Conversation

@jonathanlab
Copy link
Contributor

We had a weird condition which was caused by a toggle.
People can just click the a nav item sidebar to leave the settings page

@jonathanlab jonathanlab requested a review from a team as a code owner January 30, 2026 15:44
@charlesvien charlesvien merged commit 8756c0e into main Jan 30, 2026
12 checks passed
@charlesvien charlesvien deleted the fix/settings-nav-fix branch January 30, 2026 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants