ci: re-enable ECR push for duckgres-worker and duckgres-controlplane CDs#509
Merged
fuziontech merged 1 commit intomainfrom May 1, 2026
Merged
ci: re-enable ECR push for duckgres-worker and duckgres-controlplane CDs#509fuziontech merged 1 commit intomainfrom
fuziontech merged 1 commit intomainfrom
Conversation
Reverts the GHCR-only workaround from PR #507 now that the ECR repos exist. posthog-cloud-infra#7848 merged and the aws-accnt-root apply ran at 19:40 UTC, creating both `duckgres-worker` and `duckgres-controlplane` in account 795637471508 along with their cross-account pull policies. Restores in both workflows: - ECR_REGISTRY env var - aws-actions/configure-aws-credentials + amazon-ecr-login steps in build and manifest jobs - ECR tags in the docker/build-push-action tags list (so per-arch images push to both ECR and GHCR) - ECR docker buildx imagetools create calls in manifest assembly - For the worker default-version case, retag both ECR <sha>/latest and GHCR <sha>/latest Strips the temporary "ECR push is intentionally disabled" notes from both file headers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the GHCR-only workaround from #507 now that the ECR repos exist.
Verified via the apply log: "Apply complete! Resources: 6 added, 0 changed, 0 destroyed." (2 ECR repos + 2 lifecycle policies + 2 cross-account
aws_ecr_repository_policyentries).Changes
In both
.github/workflows/container-image-worker-cd.ymlandcontainer-image-controlplane-cd.yml:ECR_REGISTRY: xxx.dkr.ecr.us-east-1.amazonaws.comin theenv:block.aws-actions/configure-aws-credentials+amazon-ecr-loginsteps in both thebuildandmanifestjobs.docker/build-push-actiontags:lists so per-arch images push to both ECR and GHCR.docker buildx imagetools createcalls in manifest assembly.Test plan
🤖 Generated with Claude Code