admin/models-explorer: sorting, default sort, tooltips, orgs cross-model links#823
Merged
Conversation
- Click a column header to sort (▲ asc); click again to flip (▼). Numeric-aware comparison, booleans and nested object/array cells sort by JSON, empty/null values always sink to the bottom regardless of direction. - On load (and model switch) the table defaults to sorting by the first column ascending, so it opens in a defined, visible order instead of raw DB order. - Per-column header tooltips via a COLUMN_TOOLTIPS[model][column] map rendered as native title= (ⓘ marker + dotted underline). Seeded with orgs.hostname_alias explaining the SNI fallback (empty alias -> database_name -> org name).
Test Impact PlanDeterministic summary of how this PR changes tests, CI runners, and coverage-risk signals. Summary
Signals
Coverage risk: neutral or increased No coverage-reduction warnings detected. |
…l nav) The orgs table now renders: - users: a live per-org user count, clickable → opens Org Users filtered to that org. - warehouse: a 'warehouse →' link (or — when none), clickable → opens Managed Warehouses filtered to that org (warehouse PK = org name). Counts/presence are computed client-side (fetch org-users + managed-warehouses, group by org_id) because the /models/orgs listing does not preload them. Cross- model link clicks stop the row-detail handler and call selectModel(model, filter). Header tooltips added for both columns.
benben
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UX follow-ups to the models explorer (#821). Pure frontend (
static/models.html); embedded via//go:embed, ships on the next CP image build.COLUMN_TOOLTIPS[model][column]rendered as nativetitle=(violet ⓘ + dotted underline). Seeded fororgs.hostname_alias(SNI fallback),orgs.users,orgs.warehouse.userscell shows a live per-org user count → clicks into Org Users filtered to that org; thewarehousecell links to that org's Managed Warehouses row (warehouse PK = org name), or—when none. Counts/presence computed client-side (fetchorg-users+managed-warehouses, group byorg_id) since/models/orgsdoesn't preload them; link clicks callselectModel(model, filter)and don't trigger the row-detail handler.🤖 Generated with Claude Code