Remove insert-vs-alter transaction conflict check#2
Open
fuziontech wants to merge 1 commit into
Open
Conversation
Concurrent INSERT and ALTER TABLE operations (e.g., ADD COLUMN, RENAME COLUMN) on the same table should not conflict. Each data file carries its own mapping_id that describes the column layout at write time. The multi-file reader uses this mapping to correctly read files written under older schemas, so an INSERT that was planned before an ALTER can safely commit after it. This is needed for tools like sqlmesh that perform schema evolution (ALTER TABLE) on target tables while concurrent data pipelines INSERT into those same tables. Previously, the INSERT would fail with "Transaction conflict - attempting to insert into table - but another transaction has altered it" after exhausting all retries. The insert-vs-drop conflict check is preserved since a dropped table is genuinely gone. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Tools like sqlmesh perform schema evolution (
ALTER TABLE ADD COLUMN,RENAME COLUMN) as part of model materialization while concurrent data pipelines INSERT into the same tables. This causes:DuckLake retries internally (up to 100 times) but the conflict is permanent because the check always compares against the transaction's original snapshot.
Why this is safe
Each data file carries its own
mapping_id(stored inducklake_data_file) that describes the column layout at write time. TheDuckLakeMultiFileReader::CreateMappingfunction looks up the file's mapping and creates the correct column mapping for that specific file, regardless of the current table schema.When an INSERT commits after an ALTER:
mapping_iddescribing the pre-ALTER schemaducklake_column_mappingandducklake_name_mappingtables preserve the mappingducklake_schema_versionstracks which version applies at each snapshotThe insert-vs-drop conflict check is preserved since a dropped table is genuinely gone.
Test plan
transaction_insert_alter_no_conflict.testcovering:🤖 Generated with Claude Code