recording: fix observation on multiple threads in layout/draw is not supported for compose#204
Merged
marandaneto merged 4 commits intomainfrom Nov 11, 2024
Merged
recording: fix observation on multiple threads in layout/draw is not supported for compose#204marandaneto merged 4 commits intomainfrom
marandaneto merged 4 commits intomainfrom
Conversation
…supported for compose
marandaneto
commented
Nov 11, 2024
| return | ||
| } | ||
| val semanticsNodes = semanticsOwner.getAllSemanticsNodes(true) | ||
| val latch = CountDownLatch(1) |
Member
Author
There was a problem hiding this comment.
given that this method is only executed when view.isComposeView(), its fine to do thread jumping since its a requirement for compose anyway.
marandaneto
commented
Nov 11, 2024
Comment on lines
+659
to
+660
| // await for 1s max | ||
| latch.await(1000, TimeUnit.MILLISECONDS) |
Member
Author
There was a problem hiding this comment.
just an arbitrary value since it is a background thread, awaiting time wont block the screen, the time-sensitive is the part within the main thread block
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Tries to close #203
💚 How did you test it?
Running the sample with compose screen
📝 Checklist