chore: change screenshots debouncing approach to throttling#214
Merged
marandaneto merged 3 commits intomainfrom Jan 7, 2025
Merged
chore: change screenshots debouncing approach to throttling#214marandaneto merged 3 commits intomainfrom
marandaneto merged 3 commits intomainfrom
Conversation
Member
Author
|
@ioannisj would be cool to do the same on iOS if not throttling yet |
Collaborator
iOS implementation is using a timer currently. When the timer fires we check if layoutSubviews was called (which would signal that something changed on the screen). So not debouncing, kind of throttling. This means, however, that the timer is still active even when the app is idle which can be improved (we just ignore if layoutSubviews was not called). Also, configuration option is still |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Using throttling instead of debouncing, similar to iOS and Flutter now.
💚 How did you test it?
📝 Checklist