isFeatureEnabled now returns true if multivariant flag#42
Conversation
|
Actually, I am a bit confused, the so if the flag is within the response payload, it is enabled, always, then the iOS implementation is correct. Should @neilkakkar mind explaining? |
|
Decide returns all enabled flags, correct. But just because a flag is enabled doesn't mean that the API will always return true. For example, if you have a filter on Country = X on the flag, the API will return false if you're outside country X. Same for, say, if the rollout % is not 100%. |
Correct, and nice finding! |
|
|
||
| buildConfig { | ||
| useKotlinOutput() | ||
| packageName("com.posthog.internal") |

💡 Motivation and Context
By doing #41 I noticed that
isFeatureEnabledis also wrong.I also noticed that the iOS SDK never returns
falseif a flag has afalsevalue.https://github.com/PostHog/posthog-ios/blob/9298825fe26899a58b976d400254e0b050daa578/PostHog/Classes/PHGPostHog.m#L317
Is it a bug on the iOS SDK I believe, right?
💚 How did you test it?
📝 Checklist