Skip to content

fix: Send wireframe children for updated wireframes - mutation#81

Merged
marandaneto merged 2 commits intomainfrom
fix/keyboard-mutation-children
Jan 15, 2024
Merged

fix: Send wireframe children for updated wireframes - mutation#81
marandaneto merged 2 commits intomainfrom
fix/keyboard-mutation-children

Conversation

@marandaneto
Copy link
Member

@marandaneto marandaneto commented Jan 15, 2024

💡 Motivation and Context

When there are keyboard events (open/close), the view is redrawn and the wireframe has a new height due to making space for the keyboard hence the wireframe observed a mutation.
The mutation sends just the wireframe but not its children leading to all children being lost in the FE since its stateless.

💚 How did you test it?

https://us.posthog.com/project/41706/replay/5e3d9268-1d86-4d10-81dc-82239b885a40

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

@marandaneto marandaneto marked this pull request as draft January 15, 2024 14:21
@marandaneto marandaneto marked this pull request as ready for review January 15, 2024 14:37
@marandaneto marandaneto changed the title fix: send wireframe children for updated mutation fix: Send wireframe children for updated wireframes - mutation Jan 15, 2024
@marandaneto marandaneto merged commit 1093252 into main Jan 15, 2024
@marandaneto marandaneto deleted the fix/keyboard-mutation-children branch January 15, 2024 14:39
@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Next" section. Make sure the entry includes this PR's number.
Example:

## Next
- Send wireframe children for updated wireframes - mutation ([#81](https://github.com/PostHog/posthog-android/pull/81))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 73a28b6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants