Skip to content

chore: fix Elixir 1.20 warnings#127

Merged
turnipdabeets merged 2 commits into
PostHog:mainfrom
martosaur:am-elixir-1.20-warnings
Jun 3, 2026
Merged

chore: fix Elixir 1.20 warnings#127
turnipdabeets merged 2 commits into
PostHog:mainfrom
martosaur:am-elixir-1.20-warnings

Conversation

@martosaur
Copy link
Copy Markdown
Contributor

💡 Motivation and Context

Elixir 1.20 released today with a ton of new compiler checks related to the type system. For posthog sdk, there was just one warning for an unreachable clause, so let's fix it.

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran sampo add to generate a changeset file

@martosaur martosaur requested review from a team and rafaeelaudibert as code owners June 3, 2026 19:36
@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented Jun 3, 2026

Reviews (1): Last reviewed commit: "chore: fix Elixir 1.20 warnings" | Re-trigger Greptile

Copy link
Copy Markdown
Contributor

@turnipdabeets turnipdabeets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, worth updating the CI matrix in .github/workflows/ci.yml since it tops out at 1.19.x

@martosaur
Copy link
Copy Markdown
Contributor Author

Update CI versions matrix to reflect official compatibility doc!

@turnipdabeets turnipdabeets merged commit eb34c2f into PostHog:main Jun 3, 2026
25 checks passed
@martosaur martosaur deleted the am-elixir-1.20-warnings branch June 3, 2026 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants