feat: allow adding lazy loaded scripts to head to avoid hydration errors #2802
+1,797
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
11 tasks
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Contributor
Contributor
|
Size Change: +1.17 kB (+0.02%) Total Size: 5.83 MB
ℹ️ View Unchanged
|
pauldambra
force-pushed
the
chore/pd/add-failing-test
branch
from
375a514 to
c19e9e8
Compare
pauldambra
commented
Dec 21, 2025
pauldambra
changed the title
pauldambra
force-pushed
the
chore/pd/add-failing-test
branch
from
c19e9e8 to
a249b2e
Compare
paperclover
reviewed
Dec 23, 2025
paperclover
left a comment
paperclover
left a comment
There was a problem hiding this comment.
thank you. i spent a long time thinking if this was the solution or not, but wasn't fully confident in my thinking.
rafaeelaudibert
approved these changes
Dec 23, 2025
Member
rafaeelaudibert
left a comment
rafaeelaudibert
left a comment
There was a problem hiding this comment.
Yeah, should be the same! This is a breaking change in a way, any chance we could hide it behind a new defaultsor do you feel positive this is good to go?
Member
Author
|
i was thinking not breaking because there should be no action on users as a result i'll wait till the new year and deploy when i an concentrate on it i do think it'd be nice to get the SDKs in to the mono-repo so we could validate JS SDK in the app without releasing it maybe (and then keep posthog.com for validating the html snippet works) but that's not a quick thing so 🙈 |
This was referenced Jan 3, 2026
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
As Tanstack Start doesn't have yet an official posthog integration, this will greatly simplify current setup :) thanks! |
Contributor
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
@pauldambra the new year has come and gone, is there anything stopping this from being merged? |
pauldambra
force-pushed
the
chore/pd/add-failing-test
branch
from
a249b2e to
cf21f59
Compare
pauldambra
force-pushed
the
chore/pd/add-failing-test
branch
from
cf21f59 to
606f619
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
pauldambra
changed the title
pauldambra
force-pushed
the
chore/pd/add-failing-test
branch
from
606f619 to
9f4d2a4
Compare
Member
Author
|
@rafaeelaudibert i decided to be a good citizen and add this to a new default it's a low chance but someone could be bound to the existing behaviour in some unexpected way i'll merge tomorrow when i'm around to pay attention |
pauldambra
temporarily deployed
to
NPM Release
GitHub Actions
Inactive
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
avoid hydration errors #2781
when someone is using SSR and we're lazy loading scripts we have a race between react hydrating and us altering the DOM
if we manage to alter the DOM before hydration complests then we'll cause a hydration error
i don't believe we care where the script is added (since we're adding it async from code the location isn't going to affect whether it blocks) so we can add the script to the head and not have any risk of causing a hydration error
Libraries affected