Skip to content

fix: pin composer lock to php 8.2 compatible symfony clock#115

Merged
cat-ph merged 1 commit intomasterfrom
codex/fix-clock-lockfile-ci
Apr 1, 2026
Merged

fix: pin composer lock to php 8.2 compatible symfony clock#115
cat-ph merged 1 commit intomasterfrom
codex/fix-clock-lockfile-ci

Conversation

@cat-ph
Copy link
Copy Markdown
Contributor

@cat-ph cat-ph commented Apr 1, 2026

Summary

Fix CI after composer.lock was checked into master with symfony/clock v8.0.0, which requires PHP 8.4 and breaks composer install on the 8.2/8.3 jobs.

This keeps composer.json unchanged, so downstream consumers on PHP 8.4+ can still resolve Clock 8 if they want to. Only the checked-in lockfile changes for this repo.

Changes

  • downgrade locked symfony/clock from v8.0.0 to v7.4.8
  • add symfony/polyfill-php83 as required by that resolution
  • leave composer.json constraints alone

Verification

  • composer install --prefer-dist --no-progress

@cat-ph
Copy link
Copy Markdown
Contributor Author

cat-ph commented Apr 1, 2026

I think unit tests didn't run in #114 - 8.2 and 8.3 are broken when using clock v8 (noticed it on my branch in #109)

@cat-ph cat-ph requested a review from marandaneto April 1, 2026 14:58
@cat-ph cat-ph enabled auto-merge (squash) April 1, 2026 14:59
@marandaneto
Copy link
Copy Markdown
Member

ups sorry

@cat-ph cat-ph merged commit a337b8a into master Apr 1, 2026
11 checks passed
@cat-ph cat-ph deleted the codex/fix-clock-lockfile-ci branch April 1, 2026 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants