Conversation
neilkakkar
reviewed
Oct 3, 2024
Contributor
neilkakkar
left a comment
There was a problem hiding this comment.
One blocking comment, otherwise LGTM! Pragmatic approach to adding it on sdk init, I like it
Contributor
|
(also remember to bump version and changelog before merging) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Customers of error tracking want to know what repository a particular exception came from by filtering in the UI. Rather than adding some specific property (e.g.
exception_source_identifier) that would then need to be added to the JS SDK and any other language we support in future, I thought it would be easier to reuse the super properties concept found in our other SDKsI'm not tied to this approach but "PRs > Slack" and all that... Open to feedback here.
Changes
super_propertieswhen initialising the clientregistermethod seen elsewhere but didn't want to mislead customers into thinking that properties were somehow stored elsewhere (like they are in local storage). Better to make sure that they're always included when the client is initialised