fix: azure open ai delta check #203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Added a critical fix for Azure OpenAI streaming responses by implementing proper null checks for delta properties.
- Added null checks for
deltaanddelta.contentin both sync and async OpenAI clients atposthog/ai/openai/openai.pyandposthog/ai/openai/openai_async.py - Version bumped to 3.19.1 in
posthog/version.pyto reflect the bug fix - Updated CHANGELOG.md with Azure OpenAI streaming fix entry
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| accumulated_content.append(content) | ||
|
|
||
| # Process tool calls | ||
| tool_calls = getattr(chunk.choices[0].delta, "tool_calls", None) |
Contributor
There was a problem hiding this comment.
style: Consider adding the same null check for delta before accessing tool_calls to maintain consistency with the content check above
skoob13
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a check for delta before getting contents otherwise azure will not work with streaming