fix: distro requirement for analytics package #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR fixes installation requirements for the posthoganalytics package by adding the 'distro' package dependency for Linux OS detection in Python 3.9+.
- Added
distro>=1.5.0toinstall_requiresin/setup_analytics.pyfor Linux OS detection - Potential bug:
VERSIONis used insetup_analytics.pybut its import was removed - Documented fix in
/CHANGELOG.mdunder version 3.19.2
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
pauldambra
approved these changes
Mar 11, 2025
pauldambra
reviewed
Mar 11, 2025
| "monotonic>=1.5", | ||
| "backoff>=1.10.0", | ||
| "python-dateutil>2.1", | ||
| "distro>=1.5.0", # Required for Linux OS detection in Python 3.9+ |
Member
There was a problem hiding this comment.
what's the difference between where I added it and this file 🙈
Contributor
Author
There was a problem hiding this comment.
We publish the posthog package as posthoganalytics so that it doesn't clash with the module name in our main Django backend. Most customers will use posthog which is where you changed it, we use posthoganalytics which this setup file relates to
Member
There was a problem hiding this comment.
thank you, obvious once explained :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pauldambra I think you forgot to add
distrofor the analytics package