fix: feature flag request use geoip_disable #235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Fixed parameter name mismatch in feature flag requests from disable_geoip to geoip_disable to align with server expectations for controlling GeoIP lookups.
- Changed parameter name in
get_flags_decisionmethod'srequest_datadictionary inposthog/client.py - Parameter controls whether GeoIP lookups are disabled when making feature flag decisions
- No functional changes, only aligns parameter naming with server API expectations
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
dmarticus
approved these changes
May 27, 2025
Contributor
dmarticus
left a comment
dmarticus
left a comment
There was a problem hiding this comment.
ouch, thanks for fixing!
We should probably just rename that field everywhere so it's consistent but not a blocker for this change IMO.
it incorrectly used disable_geoip
Contributor
Author
|
Changing it (102 places) everywhere breaks API backward compatibility and would require some more hacking around, not worth to break it. |
orian
force-pushed
the
pawel/fix/geoip-disable
branch
from
797d050 to
95b9993
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it incorrectly used disable_geoip