Resolve polling issues with feature flags #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yakkomajuri
reviewed
May 14, 2021
Contributor
yakkomajuri
left a comment
yakkomajuri
left a comment
There was a problem hiding this comment.
Haven't worked in the codebase for a while, left one comment about flipping the daemon toggle
| def __init__(self, interval, execute, *args, **kwargs): | ||
| threading.Thread.__init__(self) | ||
| self.daemon = False | ||
| self.daemon = True # Make daemon to not interfere with program exit |
Contributor
There was a problem hiding this comment.
Do we need to enable this given we're now stopping the poller on exit?
Contributor
Author
There was a problem hiding this comment.
Indeed.
It's only when we manually shut down the runner, that the onExit part is called.
In other cases, given nothing is actively running, we don't want poll to actively block exit (which is what it does when it's not a daemon thread).
The program automatically exits when the only things running are daemon threads.
yakkomajuri
approved these changes
May 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16
Tested using
example.py: it blocked when a valid personal API key was set, but doesn't anymore.