fix: avoid overwriting consumer list when using more than one consumer #370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TueHaulund
requested review from
a team,
ksvat,
pauldambra and
veryayskiy
and removed request for
a team
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
pauldambra
approved these changes
Nov 12, 2025
Member
pauldambra
left a comment
pauldambra
left a comment
There was a problem hiding this comment.
looks correct to me
commented here https://posthog.slack.com/archives/C0113360FFV/p1762938464966359?thread_ts=1762933299.225689&cid=C0113360FFV
but we should maybe have a test here - but i didn't grok if the setup for that would be painful so not blocking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using more than one thread, the SDK would erroneously overwrite the list of consumers while starting them.