-
Notifications
You must be signed in to change notification settings - Fork 54
fix(llma): small fixes for prompt management #420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
posthog-python Compliance ReportDate: 2026-02-03 18:42:04 UTC
|
| Test | Status | Duration |
|---|---|---|
| Format Validation.Event Has Required Fields | ✅ | 518ms |
| Format Validation.Event Has Uuid | ✅ | 1508ms |
| Format Validation.Event Has Lib Properties | ✅ | 1507ms |
| Format Validation.Distinct Id Is String | ✅ | 1506ms |
| Format Validation.Token Is Present | ✅ | 1507ms |
| Format Validation.Custom Properties Preserved | ✅ | 1507ms |
| Format Validation.Event Has Timestamp | ✅ | 1507ms |
| Retry Behavior.Retries On 503 | ✅ | 6906ms |
| Retry Behavior.Does Not Retry On 400 | ✅ | 3504ms |
| Retry Behavior.Does Not Retry On 401 | ✅ | 3508ms |
| Retry Behavior.Respects Retry After Header | ❌ | 7387ms |
| Retry Behavior.Implements Backoff | ✅ | 20697ms |
| Retry Behavior.Retries On 500 | ✅ | 6666ms |
| Retry Behavior.Retries On 502 | ✅ | 6987ms |
| Retry Behavior.Retries On 504 | ✅ | 6724ms |
| Retry Behavior.Max Retries Respected | ✅ | 20809ms |
| Deduplication.Generates Unique Uuids | ✅ | 1496ms |
| Deduplication.Preserves Uuid On Retry | ✅ | 7291ms |
| Deduplication.Preserves Uuid And Timestamp On Retry | ✅ | 14188ms |
| Deduplication.Preserves Uuid And Timestamp On Batch Retry | ✅ | 6863ms |
| Deduplication.No Duplicate Events In Batch | ✅ | 1504ms |
| Deduplication.Different Events Have Different Uuids | ✅ | 1506ms |
| Compression.Sends Gzip When Enabled | ✅ | 1508ms |
| Batch Format.Uses Proper Batch Structure | ✅ | 1506ms |
| Batch Format.Flush With No Events Sends Nothing | ✅ | 1005ms |
| Batch Format.Multiple Events Batched Together | ✅ | 1505ms |
| Error Handling.Does Not Retry On 403 | ✅ | 3509ms |
| Error Handling.Does Not Retry On 413 | ✅ | 3506ms |
| Error Handling.Retries On 408 | ❌ | 6510ms |
Failures
retry_behavior.respects_retry_after_header
Retry delay too short: 880ms < 2500ms
error_handling.retries_on_408
Expected at least 2 requests, got 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 4 comments
Additional Comments (1)
Prompt To Fix With AIThis is a comment left during a code review.
Path: posthog/test/ai/test_prompts.py
Line: 373:373
Comment:
URL path needs updating from /api/projects/@current/ to /api/environments/@current/
```suggestion
"https://eu.i.posthog.com/api/environments/@current/llm_prompts/name/test-prompt/",
```
How can I resolve this? If you propose a fix, please make it concise. |
Small fixes for the prompt management implementation.