Fix feature flag 401 errors causing HTTP request storm

[GabiGrin]

Summary

• Set feature_flags = [] on 401 error to prevent repeated HTTP requests
• Matches existing behavior for 402 errors

Fixes #421

[greptile-apps]

_{2 files reviewed, 3 comments}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

Additional Comments (1)

posthog/client.py
flag_cache not cleared on 401 error

The 402 error handler clears the flag_cache (lines 1356-1357), but the 401 handler doesn't. For consistency and to ensure no stale cached evaluations remain, the flag cache should also be cleared here.

                self.feature_flags = []
                self.group_type_mapping = {}
                self.cohorts = {}
                
                # Clear flag cache when unauthorized
                if self.flag_cache:
                    self.flag_cache.clear()
                
                if self.debug:

Prompt To Fix With AI

This is a comment left during a code review.
Path: posthog/client.py
Line: 1338:1345

Comment:
`flag_cache` not cleared on 401 error

The 402 error handler clears the `flag_cache` (lines 1356-1357), but the 401 handler doesn't. For consistency and to ensure no stale cached evaluations remain, the flag cache should also be cleared here.

```suggestion
                self.feature_flags = []
                self.group_type_mapping = {}
                self.cohorts = {}
                
                # Clear flag cache when unauthorized
                if self.flag_cache:
                    self.flag_cache.clear()
                
                if self.debug:
```

How can I resolve this? If you propose a fix, please make it concise.

[dustinbyrne]

Thanks @GabiGrin! This looks great.