fix(llma): graceful fallback in claude_agent_sdk wrapper#495
Merged
andrewm4894 merged 8 commits intomasterfrom Apr 9, 2026
Merged
fix(llma): graceful fallback in claude_agent_sdk wrapper#495andrewm4894 merged 8 commits intomasterfrom
andrewm4894 merged 8 commits intomasterfrom
Conversation
… not configured When PostHog is not configured (no API key), the query() convenience function now catches the initialization error and falls back to the plain claude_agent_sdk.query() with a warning log instead of crashing. The wrapper should be fail-safe — instrumentation is additive and must never break the underlying SDK call.
Contributor
posthog-python Compliance ReportDate: 2026-04-09 20:11:09 UTC ✅ All Tests Passed!0/0 tests passed |
This reverts commit 480bed9.
Contributor
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 480bed9877
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Address review feedback: - Narrow except clause to (ValueError, RuntimeError) to avoid swallowing real bugs - Fix test to use _make_result_message() (the actual helper name)
lucasheriques
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
posthoganalytics.ai.claude_agent_sdk.query()convenience function crashes withValueError("API key is required")when PostHog is not configured. This breaks the "drop-in replacement" contract — callers who import the wrapper expecting fail-safe instrumentation get a hard crash instead.This caused StampHog (PostHog's PR approval agent) to fail on every review after
posthoganalytics7.10.x shipped theai.claude_agent_sdkmodule. See PostHog/posthog#53964 for the downstream fix.The same
client or setup()pattern exists across all AI wrappers (openai, anthropic, gemini, langchain, openai_agents) — they would all crash the same way. This PR scopes the fix toclaude_agent_sdkonly; a broader hardening pass can follow.Changes
In the
query()convenience function, catch initialization errors and fall back to the plainclaude_agent_sdk.query()with a warning log. The wrapper is now fail-safe: if PostHog isn't configured, it transparently delegates to the original SDK.How did you test this code?
Added
TestQueryGracefulFallback— patchesPostHogClaudeAgentProcessorto raiseValueErrorand verifies messages are still yielded from the original query.