Skip to content

chore: remove v prefix from release tags#524

Merged
marandaneto merged 1 commit intomainfrom
chore/remove-v-prefix-from-release-tags
Apr 20, 2026
Merged

chore: remove v prefix from release tags#524
marandaneto merged 1 commit intomainfrom
chore/remove-v-prefix-from-release-tags

Conversation

@marandaneto
Copy link
Copy Markdown
Member

💡 Motivation and Context

This ports the same release-workflow fix from posthog-go to posthog-python. The current workflow hardcodes a v prefix when creating the Git tag and GitHub release, but this repo should use plain semantic versions like 1.2.3.

💚 How did you test it?

  • ruby -e 'require "yaml"; YAML.load_file(".github/workflows/release.yml"); puts "yaml-ok"'
  • git diff --check

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran sampo add to generate a changeset file
  • Added the release label to the PR

@marandaneto marandaneto requested a review from a team as a code owner April 20, 2026 07:15
@marandaneto marandaneto enabled auto-merge (squash) April 20, 2026 07:15
@socket-security
Copy link
Copy Markdown

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented Apr 20, 2026

Comments Outside Diff (1)

  1. .github/workflows/release.yml, line 148 (link)

    P2 Remaining v prefix in commit message

    This commit message still includes the v prefix, which is inconsistent with the other changes in this PR that strip it from the git tag, GitHub release, PostHog event payload, and Slack notification.

    Prompt To Fix With AI
    This is a comment left during a code review.
    Path: .github/workflows/release.yml
    Line: 148
    
    Comment:
    **Remaining `v` prefix in commit message**
    
    This commit message still includes the `v` prefix, which is inconsistent with the other changes in this PR that strip it from the git tag, GitHub release, PostHog event payload, and Slack notification.
    
    
    
    How can I resolve this? If you propose a fix, please make it concise.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix All With AI
This is a comment left during a code review.
Path: .github/workflows/release.yml
Line: 148

Comment:
**Remaining `v` prefix in commit message**

This commit message still includes the `v` prefix, which is inconsistent with the other changes in this PR that strip it from the git tag, GitHub release, PostHog event payload, and Slack notification.

```suggestion
          commit_message: "chore: Release ${{ steps.sampo-release.outputs.new_version }}"
```

How can I resolve this? If you propose a fix, please make it concise.

Reviews (1): Last reviewed commit: "chore: remove v prefix from release tags" | Re-trigger Greptile

@github-actions
Copy link
Copy Markdown
Contributor

posthog-python Compliance Report

Date: 2026-04-20 07:18:33 UTC
Duration: 160005ms

✅ All Tests Passed!

30/30 tests passed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 516ms
Format Validation.Event Has Uuid 1508ms
Format Validation.Event Has Lib Properties 1507ms
Format Validation.Distinct Id Is String 1507ms
Format Validation.Token Is Present 1507ms
Format Validation.Custom Properties Preserved 1507ms
Format Validation.Event Has Timestamp 1507ms
Retry Behavior.Retries On 503 9519ms
Retry Behavior.Does Not Retry On 400 3506ms
Retry Behavior.Does Not Retry On 401 3508ms
Retry Behavior.Respects Retry After Header 9515ms
Retry Behavior.Implements Backoff 23533ms
Retry Behavior.Retries On 500 7505ms
Retry Behavior.Retries On 502 7512ms
Retry Behavior.Retries On 504 7510ms
Retry Behavior.Max Retries Respected 23531ms
Deduplication.Generates Unique Uuids 1497ms
Deduplication.Preserves Uuid On Retry 7514ms
Deduplication.Preserves Uuid And Timestamp On Retry 14522ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 7504ms
Deduplication.No Duplicate Events In Batch 1508ms
Deduplication.Different Events Have Different Uuids 1507ms
Compression.Sends Gzip When Enabled 1507ms
Batch Format.Uses Proper Batch Structure 1507ms
Batch Format.Flush With No Events Sends Nothing 1005ms
Batch Format.Multiple Events Batched Together 1505ms
Error Handling.Does Not Retry On 403 3509ms
Error Handling.Does Not Retry On 413 3508ms
Error Handling.Retries On 408 7514ms

Feature_Flags Tests

1/1 tests passed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 516ms

@marandaneto marandaneto merged commit 8d82855 into main Apr 20, 2026
27 checks passed
@marandaneto marandaneto deleted the chore/remove-v-prefix-from-release-tags branch April 20, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants