Skip to content

chore: trigger releases from main changesets#548

Merged
marandaneto merged 3 commits intomainfrom
chore/release-on-main-push
May 4, 2026
Merged

chore: trigger releases from main changesets#548
marandaneto merged 3 commits intomainfrom
chore/release-on-main-push

Conversation

@marandaneto
Copy link
Copy Markdown
Member

@marandaneto marandaneto commented May 4, 2026

💡 Motivation and Context

Standardize SDK releases so they are triggered by pushes to main containing release changesets, rather than by PR labels or pull_request.closed events.

Changes

  • Updated the release workflow to run on push to main for .sampo/changesets/**, while keeping manual workflow_dispatch
  • Removed release-label and bump-label checks from the release flow
  • Added [skip ci] to release version-bump commits and narrowed release path filters to changeset markdown files to avoid re-triggering release workflows on consumed changeset deletions
  • Updated only the release-label parts of the release docs and PR checklist

💚 How did you test it?

  • Parsed the updated release workflow YAML locally
  • Verified the release workflow no longer references pull_request, PR labels, or bump labels
  • Verified PR templates no longer ask for release labels

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran sampo add to generate a changeset file (not needed for this release-process-only change)

@socket-security
Copy link
Copy Markdown

socket-security Bot commented May 4, 2026

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

@marandaneto marandaneto marked this pull request as ready for review May 4, 2026 12:47
@marandaneto marandaneto requested a review from a team as a code owner May 4, 2026 12:47
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps Bot commented May 4, 2026

Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
RELEASING.md:18
**Capitalization typo after comma**

"The" should be lowercase — it continues the same sentence started by "After approval,".

```suggestion
After approval, the workflow runs Sampo, publishes both `posthog` and the `posthoganalytics` mirror package to PyPI, tags the release, and creates a GitHub Release.
```

Reviews (1): Last reviewed commit: "chore: skip release workflow on version ..." | Re-trigger Greptile

Comment thread RELEASING.md Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 4, 2026

posthog-python Compliance Report

Date: 2026-05-04 14:12:06 UTC
Duration: 4674466ms

⚠️ Some Tests Failed

29/45 tests passed, 16 failed


Capture Tests

29/29 tests passed

View Details
Test Status Duration
Format Validation.Event Has Required Fields 518ms
Format Validation.Event Has Uuid 1508ms
Format Validation.Event Has Lib Properties 1506ms
Format Validation.Distinct Id Is String 1508ms
Format Validation.Token Is Present 1507ms
Format Validation.Custom Properties Preserved 1507ms
Format Validation.Event Has Timestamp 1507ms
Retry Behavior.Retries On 503 9519ms
Retry Behavior.Does Not Retry On 400 3506ms
Retry Behavior.Does Not Retry On 401 3508ms
Retry Behavior.Respects Retry After Header 9515ms
Retry Behavior.Implements Backoff 23528ms
Retry Behavior.Retries On 500 7502ms
Retry Behavior.Retries On 502 7516ms
Retry Behavior.Retries On 504 7508ms
Retry Behavior.Max Retries Respected 23532ms
Deduplication.Generates Unique Uuids 1498ms
Deduplication.Preserves Uuid On Retry 7511ms
Deduplication.Preserves Uuid And Timestamp On Retry 14525ms
Deduplication.Preserves Uuid And Timestamp On Batch Retry 7504ms
Deduplication.No Duplicate Events In Batch 1508ms
Deduplication.Different Events Have Different Uuids 1507ms
Compression.Sends Gzip When Enabled 1507ms
Batch Format.Uses Proper Batch Structure 1507ms
Batch Format.Flush With No Events Sends Nothing 1005ms
Batch Format.Multiple Events Batched Together 1506ms
Error Handling.Does Not Retry On 403 3509ms
Error Handling.Does Not Retry On 413 3508ms
Error Handling.Retries On 408 7514ms

Feature_Flags Tests

⚠️ 0/16 tests passed, 16 failed

View Details
Test Status Duration
Request Payload.Request With Person Properties Device Id 504ms
Request Payload.Flags Request Uses V2 Query Param 300505ms
Request Payload.Flags Request Hits Flags Path Not Decide 300943ms
Request Payload.Flags Request Omits Authorization Header 301011ms
Request Payload.Token In Flags Body Matches Init 301037ms
Request Payload.Groups Round Trip 301023ms
Request Payload.Groups Default To Empty Object 300953ms
Request Payload.Person Properties Distinct Id Auto Populated When Caller Omits It 301048ms
Request Payload.Disable Geoip False Propagates As Geoip Disable False 301000ms
Request Payload.Disable Geoip Omitted Defaults To False 300993ms
Request Payload.Flag Keys To Evaluate Contains Only Requested Key 300922ms
Request Lifecycle.No Flags Request On Init Alone 301004ms
Request Lifecycle.No Flags Request On Normal Capture 301053ms
Request Lifecycle.Two Flag Calls Produce Two Remote Requests 300995ms
Request Lifecycle.Mock Response Value Is Returned To Caller 301004ms
Side Effect Events.Get Feature Flag Captures Feature Flag Called Event 300949ms

Failures

request_payload.request_with_person_properties_device_id

Field 'token' not found in /flags request body at path 'token'. Available keys: ['distinct_id', 'groups', 'person_properties', 'group_properties', 'geoip_disable', 'device_id', 'flag_keys_to_evaluate', 'sentAt', 'api_key']

request_payload.flags_request_uses_v2_query_param

No error message

request_payload.flags_request_hits_flags_path_not_decide

No error message

request_payload.flags_request_omits_authorization_header

No error message

request_payload.token_in_flags_body_matches_init

No error message

request_payload.groups_round_trip

No error message

request_payload.groups_default_to_empty_object

No error message

request_payload.person_properties_distinct_id_auto_populated_when_caller_omits_it

No error message

request_payload.disable_geoip_false_propagates_as_geoip_disable_false

No error message

request_payload.disable_geoip_omitted_defaults_to_false

No error message

request_payload.flag_keys_to_evaluate_contains_only_requested_key

No error message

request_lifecycle.no_flags_request_on_init_alone

No error message

request_lifecycle.no_flags_request_on_normal_capture

No error message

request_lifecycle.two_flag_calls_produce_two_remote_requests

No error message

request_lifecycle.mock_response_value_is_returned_to_caller

No error message

side_effect_events.get_feature_flag_captures_feature_flag_called_event

No error message

@marandaneto marandaneto enabled auto-merge (squash) May 4, 2026 14:21
@marandaneto marandaneto merged commit d69038a into main May 4, 2026
26 checks passed
@marandaneto marandaneto deleted the chore/release-on-main-push branch May 4, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants