chore: stabilize sdk compliance adapter#617
Merged
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "chore: stabilize sdk compliance adapter" | Re-trigger Greptile |
Contributor
posthog-python Compliance ReportDate: 2026-05-22 12:07:28 UTC ✅ All Tests Passed!45/45 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 16/16 tests passed View Details
|
bc3f7bd to
b83bd24
Compare
b83bd24 to
131b925
Compare
Member
Author
|
ok CI is happy now |
Contributor
|
Reviews (2): Last reviewed commit: "ci: pin sdk compliance harness sha" | Re-trigger Greptile |
ioannisj
approved these changes
May 22, 2026
ioannisj
left a comment
There was a problem hiding this comment.
Very low context approve but changes seem reasonable to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
Fix the SDK compliance adapter state handling for the Feature_Flags compliance suite.
The adapter could deadlock during test reset because it held
SDKState.lockwhileclient.shutdown()flushed pending events through the patched transport, which also records requests under the same lock. Feature flag side-effect events could also be flushed after an adapter action returned, leaking into the next compliance test's mock-server state.This also updates the compliance workflow to use the released
posthog-sdk-test-harnessfix from PostHog/posthog-sdk-test-harness#19. The reusable workflow is pinned to full commit SHA85e2901ea3260a28e07a83086d59b4fb4dfc814f, and the harness image is pinned by digest.💚 How did you test it?
uv run --with flask --with python-dateutil python sdk_compliance_adapter/adapter.py/Users/marandaneto/Github/posthog-sdk-test-harness:uv run posthog-test-harness run --adapter-url http://localhost:18080 --suite feature_flags --output text --concurrency 1uv run --with pyyaml python - <<'PY' ... yaml.safe_load(...) ... PYdocker manifest inspect 'ghcr.io/posthog/sdk-test-harness:main-85e2901@sha256:4c8eac34e7ff66554a2c6947788c0a42b82456bc949c03bd8f6b9a10bef23ef5'📝 Checklist
If releasing new changes
sampo addto generate a changeset file