fix: stop duplicating distinct_id in flags person properties#722
Merged
Conversation
Contributor
|
Reviews (1): Last reviewed commit: "fix: stop duplicating distinct_id in fla..." | Re-trigger Greptile |
Contributor
posthog-python Compliance ReportDate: 2026-07-02 11:45:38 UTC ✅ All Tests Passed!46/46 tests passed Capture Tests✅ 29/29 tests passed View Details
Feature_Flags Tests✅ 17/17 tests passed View Details
|
Contributor
|
Reviews (2): Last reviewed commit: "Format local distinct_id evaluation chan..." | Re-trigger Greptile |
ioannisj
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 Motivation and Context
/flagsrequests already senddistinct_idat the top level. Automatically copying the same value intoperson_properties.distinct_idsends duplicated identity data and differs from the desired payload shape.This PR keeps the top-level
distinct_idand stops automatically injecting it intoperson_properties. Caller-provided person properties are still forwarded.💚 How did you test it?
uv run --extra test pytest posthog/test/test_client.py posthog/test/test_feature_flags.py -q📝 Checklist
If releasing new changes
sampo addto generate a changeset file🤖 Agent context
Autonomy: Human-driven (agent-assisted)
This was implemented with pi in dedicated git worktrees. I changed the /flags request construction so SDKs keep the top-level distinct_id while no longer auto-copying it into person_properties; explicit caller-provided person_properties['distinct_id'] values are still preserved where covered.