Add ability to disable SSL verification#11
Merged
yakkomajuri merged 1 commit intoPostHog:masterfrom Nov 22, 2021
taobojlen:allow-disabling-ssl-verification
Merged
Add ability to disable SSL verification#11yakkomajuri merged 1 commit intoPostHog:masterfrom taobojlen:allow-disabling-ssl-verification
yakkomajuri merged 1 commit intoPostHog:masterfrom
taobojlen:allow-disabling-ssl-verification
Conversation
yakkomajuri
approved these changes
Nov 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use case: we have a staging environment with its own PostHog instance. It's not exposed to the internet, and uses a self-signed SSL certificate. This staging instance is useful for development. We currently need to manually change
transport.rbto disable SSL verification, otherwise posthog-ruby's requests fail.This PR makes it easier to use PostHog behind a self-signed SSL certificate by passing in an option to
PostHog::Client.new. This will also allow us to send events from our staging Ruby app.This is maybe a pretty niche requirement, so understandable if you don't want to merge it, but it'd be useful for us! I've tested these modifications with our Ruby app and it works.