Skip to content

chore: simplify ruby release token usage#127

Merged
marandaneto merged 4 commits intomainfrom
chore/simplify-release-token-usage
Apr 16, 2026
Merged

chore: simplify ruby release token usage#127
marandaneto merged 4 commits intomainfrom
chore/simplify-release-token-usage

Conversation

@marandaneto
Copy link
Copy Markdown
Member

@marandaneto marandaneto commented Apr 16, 2026

💡 Motivation and Context

The Ruby release workflow was requesting a GitHub App token twice, once in version-bump and again in publish. Other SDK repos like posthog-react-native-session-replay only need the app token in the version-bump job, so the duplicate setup adds unnecessary complexity and another failure point.

This PR also fixes the next release failure mode: once the version bump updates lib/posthog/version.rb, Bundler sees the path gem version change and requires Gemfile.lock to be refreshed before the publish job can run with frozen lockfile settings.

This PR includes a patch changeset so merging it can exercise the release automation again.

💚 How did you test it?

  • compared the Ruby workflow with posthog-react-native-session-replay/.github/workflows/release.yml
  • updated publish to use the default checkout/token flow and kept the GitHub App token only in version-bump
  • parsed .github/workflows/release.yml with Ruby YAML to confirm the workflow file is still valid
  • added a patch changeset and verified pnpm changeset status computes the next release as 3.6.3
  • locally changed the gem version and verified bundle lock updates Gemfile.lock to match, which addresses the frozen lockfile failure in publish

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • I updated the docs if needed.
  • No breaking change or entry added to the changelog.

If releasing new changes

  • Ran pnpm changeset to generate a changeset file
  • Added the release label to the PR

@marandaneto marandaneto requested a review from a team as a code owner April 16, 2026 14:03
@marandaneto marandaneto merged commit d83df86 into main Apr 16, 2026
14 checks passed
@marandaneto marandaneto deleted the chore/simplify-release-token-usage branch April 16, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant