Skip to content

Fix namespacing of PostHog/FeatureFlag#65

Closed
diddeb wants to merge 1 commit intoPostHog:mainfrom
diddeb:fix-namespacing-of-featureflag
Closed

Fix namespacing of PostHog/FeatureFlag#65
diddeb wants to merge 1 commit intoPostHog:mainfrom
diddeb:fix-namespacing-of-featureflag

Conversation

@diddeb
Copy link
Copy Markdown

@diddeb diddeb commented May 20, 2025

The FeatureFlag class in this project isn’t scoped under the PostHog namespace, which causes a conflict in our application. Given how common the name FeatureFlag is, this kind of collision is easy to run into. It’s avoidable by properly namespacing it under PostHog...

@pauldambra
Copy link
Copy Markdown
Member

Thanks for the PR 🙌

we're addressing this in #63 any minute now

@pauldambra
Copy link
Copy Markdown
Member

(also see #60)

@pauldambra
Copy link
Copy Markdown
Member

if you update to posthog ruby 3.0 this should be resolved for you

(i assuming you don't need ruby 2 support 🙏)

@diddeb
Copy link
Copy Markdown
Author

diddeb commented May 20, 2025

Perfect! Thanks @pauldambra. 👌🏻

@diddeb diddeb closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants