feat: Update player to rrweb2#15113
Merged
pauldambra merged 3 commits intomasterfrom Apr 18, 2023
Merged
Conversation
Contributor
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We are benefitting from the recorder side of rrweb2 but not the player side. Noticed this when filing a bug report with them - a recording worked for them but not us and I realised that we still use the older version.
Closes #15109
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
How did you test this code?
export-borked-ionic-recording.json.zip
Updated the player to the latest version and it worked great #15109
@pauldambra would be good to test properly locally and see if it looks good to you as well. Then I say lets risk it and push this out.