feat(cdp): introduce hogwatcher for transforms#30217
Merged
meikelmosby merged 72 commits intomasterfrom Mar 26, 2025
Merged
Conversation
…ventEstimates.tsx Co-authored-by: Ben White <ben@posthog.com>
benjackwhite
previously requested changes
Mar 21, 2025
plugin-server/src/cdp/hog-transformations/hog-transformer.service.ts
Outdated
Show resolved
Hide resolved
Base automatically changed from
feat/meikel/filters-in-hog-transforms
to
master
March 21, 2025 14:35
…ce-hogwatcher-for-transforms # Conflicts: # plugin-server/src/cdp/hog-transformations/hog-transformer.service.test.ts # plugin-server/src/cdp/hog-transformations/hog-transformer.service.ts # plugin-server/src/config/config.ts
Contributor
|
Size Change: +3.78 kB (+0.04%) Total Size: 9.75 MB
|
MarconLP
approved these changes
Mar 25, 2025
pl
reviewed
Mar 25, 2025
plugin-server/src/cdp/hog-transformations/hog-transformer.service.ts
Outdated
Show resolved
Hide resolved
pl
approved these changes
Mar 26, 2025
You were on vacy and pawel did the review.
meikelmosby
added a commit
that referenced
this pull request
Mar 26, 2025
This reverts commit 76e9ddf.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
we want transformations to also be degraded if they are bad functions that would harm over time. for now we only want to log out if we would have disabled a functions but not actually skip it as we just want to get a feeling for it. we also track the execution time for each operation to get a feeling if we can run this in our production pipeline or if the calls to redis would be too expensive and would eventually slow down ingestion a lot.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?