feat(project-tree): basic search#30228
Merged
mariusandra merged 8 commits intomasterfrom Mar 21, 2025
Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
This PR moves project tree search from client-side to server-side implementation, enabling search across all items rather than just loaded ones, with a new flat search view for results.
- Added
displayNameprop toLemonTreecomponent in/frontend/src/lib/lemon-ui/LemonTree/LemonTree.tsxfor custom search result rendering - Implemented server-side search with pagination in
/frontend/src/layout/panel-layout/ProjectTree/projectTreeLogic.tsx, removing Fuse.js client search - Added
convertFileSystemEntryToFlatTreeDataItemin/frontend/src/layout/panel-layout/ProjectTree/utils.tsxfor search result display with path highlighting - Modified
fileSystem.listAPI in/frontend/src/lib/api.tsto support search parameter in backend requests
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| replaySingle: (id: string): string => `/replay/${id}`, | ||
| replayFilePlayback: (): string => '/replay/file-playback', | ||
| replaySettings: (): string => '/replay/settings', | ||
| replaySettings: (sectionId?: string): string => `/replay/settings${sectionId ? `?sectionId=${sectionId}` : ''}`, |
Contributor
There was a problem hiding this comment.
style: Template literal could be simplified to use URL parameters instead of string concatenation for better URL handling
Contributor
|
Size Change: +43 B (0%) Total Size: 9.75 MB ℹ️ View Unchanged
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The project tree search was working only client-side, which was a problem since you normally didn't have all the items loaded.
Changes
How did you test this code?
Clicked around in the UI