fix: Issues with parsing group properties

[benjackwhite]

Problem

Small PR to fix issues with the original loader

Changes

• Fixes filtering list to check the length of the team functions
• Fixes the global properties to be "unknown" record values to force type level warnings to validate
• Fixes areas where this is an issue particularly in the groups loader
• Adds tests to cover these kinds of issues

Follow up

• Follow up PR to ingestion to forbid groups shape at ingestion level

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

[greptile-apps]

PR Summary

This PR focuses on improving type safety and validation in the PostHog plugin server's group properties handling. Here's a concise summary of the key changes:

• Changed properties type from Record<string, any> to Record<string, unknown> in HogFunctionInvocationGlobals to enforce stricter type checking
• Fixed team functions filtering to check array length (!teamHogFunctions.length) instead of falsy values
• Added validation for $groups property to ensure correct object structure with string keys/values
• Added type checking for $hog_function_execution_count in postHogCapture to properly handle numeric values
• Added test coverage for invalid group properties handling and team filtering scenarios

The changes appear well-structured with good test coverage, focusing on improving data validation and type safety throughout the codebase.

_{10 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile}