chore(temporal): Add PostHog error tracking back in Temporal#30241
Merged
chore(temporal): Add PostHog error tracking back in Temporal#30241
Conversation
…flows" This reverts commit e3a9487.
Contributor
There was a problem hiding this comment.
PR Summary
Reintroduces PostHog error tracking functionality in Temporal workflows to help diagnose workflow blocking issues.
- Added
PostHogClientInterceptorback to worker interceptors list in/posthog/temporal/common/worker.py - Re-enabled error tracking tests in
/posthog/temporal/tests/common/test_error_tracking.pyby removing skip decorator - Test suite verifies both PostHog and Sentry capture workflow/activity exceptions with proper metadata
- Maintains existing 5-minute graceful shutdown timeout and 5-second heartbeat interval settings
2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
EDsCODE
approved these changes
Mar 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Something is blocking our Temporal batch export workflows but it's not the PostHog client.
Changes
Come back PostHog client, we were wrong to doubt you ;)
👉 Stay up-to-date with PostHog coding conventions for a smoother review.