Skip to content

chore(temporal): Add PostHog error tracking back in Temporal#30241

Merged
rossgray merged 1 commit intomasterfrom
add-ph-error-tracking-back
Mar 21, 2025
Merged

chore(temporal): Add PostHog error tracking back in Temporal#30241
rossgray merged 1 commit intomasterfrom
add-ph-error-tracking-back

Conversation

@rossgray
Copy link
Contributor

Problem

Something is blocking our Temporal batch export workflows but it's not the PostHog client.

Changes

Come back PostHog client, we were wrong to doubt you ;)

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

@rossgray rossgray requested a review from a team March 20, 2025 17:43
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Reintroduces PostHog error tracking functionality in Temporal workflows to help diagnose workflow blocking issues.

  • Added PostHogClientInterceptor back to worker interceptors list in /posthog/temporal/common/worker.py
  • Re-enabled error tracking tests in /posthog/temporal/tests/common/test_error_tracking.py by removing skip decorator
  • Test suite verifies both PostHog and Sentry capture workflow/activity exceptions with proper metadata
  • Maintains existing 5-minute graceful shutdown timeout and 5-second heartbeat interval settings

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@rossgray rossgray merged commit a1f6d21 into master Mar 21, 2025
91 checks passed
@rossgray rossgray deleted the add-ph-error-tracking-back branch March 21, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants