feat: hide upgrade CTAs from and show owner to managed accounts by pawel-cebula · Pull Request #30247 · PostHog/posthog

pawel-cebula · 2025-03-20T18:36:20Z

Problem

We've been showing upgrade related CTAs to managed accounts, which has been confusing to them and was often at odds with the sales team efforts

Changes

Following on from billing changes (https://github.com/PostHog/billing/pull/1155), which now sync Vitally account owner information and return it via billing API

Hides upgrade related CTAs on the billing page from managed accounts
Shows account owner information in the menu, at the bottom of the CURRENT ORGANIZATION section, since the account owner is on a billing organization level, allowing click-to-copy

Alternative options considered

Link to community profile page - no private contact option there, just a public AMA. We could add contact details there too, maybe by adding some custom query param, but doesn't feel like adding more steps is helpful and my assumption is that accounts know their AEs/CSMs already.
Surveys - briefly looked into using surveys here as a contact form - definitely a bit of a stretch but doable. I'm not convinced about the ROI on this though.

For more context see

Does this work well for both Cloud and self-hosted?

Cloud only

How did you test this code?

Manually (see below and Loom: https://www.loom.com/share/80f127f1d6644b8da4f07e7cf031b11d)

…upgrade and credit CTAs from managed accounts

greptile-apps

PR Summary

This PR adds functionality to hide upgrade CTAs from managed accounts and display account owner information in the UI, improving the experience for managed accounts and aligning with sales team efforts.

Added isManagedAccount selector in frontend/src/scenes/billing/billingLogic.tsx to determine account status based on owner presence
Added new account_owner field with email and name properties to BillingType interface in frontend/src/types.ts
Added AccountOwner component in frontend/src/layout/navigation/TopBar/AccountPopover.tsx with click-to-copy functionality
Modified CreditCTAHero and Billing components to conditionally hide upgrade CTAs for managed accounts
Added event tracking in eventUsageLogic.ts for account owner information interactions

_{6 file(s) reviewed, 1 comment(s)}
_{Edit PR Review Bot Settings | Greptile}

frontend/src/layout/navigation/TopBar/AccountPopover.tsx

github-actions · 2025-03-20T18:47:57Z

Size Change: +278 B (0%)

Total Size: 9.75 MB

ℹ️ View Unchanged

Filename	Size	Change
`frontend/dist/toolbar.js`	9.75 MB	+278 B (0%)

_{compressed-size-action}

frontend/src/scenes/billing/CreditCTAHero.tsx

frontend/src/scenes/billing/Billing.tsx

zlwaterfield · 2025-03-20T19:18:58Z

frontend/src/scenes/billing/Billing.tsx

            ) : null}

-            {!billing?.has_active_subscription && !billing?.trial && platformAndSupportProduct && (
+            {!isManagedAccount && !billing?.has_active_subscription && !billing?.trial && platformAndSupportProduct && (


This change probably conflicts with your other PR - also managed accounts shouldn't be on free accounts so I think this won't be needed.

This change probably conflicts with your other PR

Yup will see what gets merged first and resolve conflicts then

also managed accounts shouldn't be on free accounts so I think this won't be needed.

I assumed so too initially but then thought that maybe an account gets AE/CSM assigned in Vitally when they reach out and start convo but before they sign. Will confirm with Mine.

Simon replied

Q: Can an account be managed (get AE/CSM assigned in Vitally) before becoming a paying customer?

A: Yes they might do if the AE is managing them through a trial

Q: Got it and technically could they already get AE/CSM assigned before starting a trial? E.g. when they reach out to the team as a prospect. Or AE/CSM would only get assigned once at least on trial?

A: We’d only assign them in Vitally once having spoken with them and got them on a trial

So technically it's not needed since we'd hide this already if they're on the trial but I'd still lean towards keeping this check to make it future proof in case sales process changes?

We do have cta in other places so it's not really hiding all of them but I'm ok with this change for now.

Got it, will keep it then and try to track down other places where we might want to hide them (might do that as a follow up so that we can merge this?)

frontend/src/layout/navigation/TopBar/AccountPopover.tsx

…n story

posthog-bot · 2025-03-21T09:44:32Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-03-21T12:39:28Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 4)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-03-21T14:03:56Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 4)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-03-21T15:10:07Z

📸 UI snapshots have been updated

2 snapshot changes in total. 0 added, 2 modified, 0 deleted:

chromium: 0 added, 2 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

posthog-bot · 2025-03-21T15:19:33Z

📸 UI snapshots have been updated

1 snapshot changes in total. 0 added, 1 modified, 0 deleted:

chromium: 0 added, 1 modified, 0 deleted (diff for shard 5)
webkit: 0 added, 0 modified, 0 deleted

Triggered by this commit.

👉 Review this PR's diff of snapshots.

…ble to false via billing api response

pawel-cebula added 5 commits March 19, 2025 10:19

add account_owner to BillingType, add isAccountManagedSelector, hide …

66fd8c3

…upgrade and credit CTAs from managed accounts

add AccountOwner to AccountPopover with copy email interation

10a34b9

longer tooltip

bc44256

Merge remote-tracking branch 'origin/master' into account-owner-ui

ff2537c

even tracking

cd7b661

pawel-cebula requested review from Scott-Sowers-PostHog, joshsny, minekansu, patricio-posthog and zlwaterfield March 20, 2025 18:36

greptile-apps bot reviewed Mar 20, 2025

View reviewed changes

frontend/src/layout/navigation/TopBar/AccountPopover.tsx Show resolved Hide resolved

zlwaterfield reviewed Mar 20, 2025

View reviewed changes

pawel-cebula and others added 4 commits March 21, 2025 10:07

Merge remote-tracking branch 'origin/master' into account-owner-ui

b76ca9f

add account_owner to _billing fixture so that it's shown in navigatio…

5190806

…n story

Merge remote-tracking branch 'origin/master' into account-owner-ui

1d2f888

Update UI snapshots for chromium (5)

ba4fb63

pawel-cebula and others added 3 commits March 21, 2025 13:18

exclude account_owner in BillingPurchaseCreditsModal story

0c542f9

accountpopover snapshot

9ab879b

Update UI snapshots for chromium (4)

7e39513

pawel-cebula and others added 2 commits March 21, 2025 14:54

fix navigation snapshot

3b2b31d

Update UI snapshots for chromium (4)

8bbdc0b

pawel-cebula and others added 2 commits March 21, 2025 16:00

fix snapshot with credits

e5ded5e

Update UI snapshots for chromium (5)

50f0ab5

Update UI snapshots for chromium (5)

5967859

remove isManagedAccount checks for credits cta since we now set eligi…

f1a3004

…ble to false via billing api response

pawel-cebula requested a review from zlwaterfield March 21, 2025 15:43

zlwaterfield approved these changes Mar 21, 2025

View reviewed changes

Merge remote-tracking branch 'origin/master' into account-owner-ui

508ae2a

pawel-cebula merged commit 2eb16cf into master Mar 21, 2025
109 checks passed

pawel-cebula deleted the account-owner-ui branch March 21, 2025 18:02

Conversation

pawel-cebula commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Problem

Changes

Does this work well for both Cloud and self-hosted?

How did you test this code?

Uh oh!

greptile-apps bot left a comment

Choose a reason for hiding this comment

PR Summary

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zlwaterfield Mar 20, 2025

Choose a reason for hiding this comment

Uh oh!

pawel-cebula Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pawel-cebula Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zlwaterfield Mar 21, 2025

Choose a reason for hiding this comment

Uh oh!

pawel-cebula Mar 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

posthog-bot commented Mar 21, 2025

📸 UI snapshots have been updated

Uh oh!

posthog-bot commented Mar 21, 2025

📸 UI snapshots have been updated

Uh oh!

posthog-bot commented Mar 21, 2025

📸 UI snapshots have been updated

Uh oh!

posthog-bot commented Mar 21, 2025

📸 UI snapshots have been updated

Uh oh!

posthog-bot commented Mar 21, 2025

📸 UI snapshots have been updated

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pawel-cebula commented Mar 20, 2025 •

edited

Loading

github-actions bot commented Mar 20, 2025 •

edited

Loading

pawel-cebula Mar 21, 2025 •

edited

Loading

pawel-cebula Mar 21, 2025 •

edited

Loading

pawel-cebula Mar 21, 2025 •

edited

Loading