fix: summarize responses is now dismisseable in surveys#30254
Merged
marandaneto merged 5 commits intomasterfrom Mar 21, 2025
Merged
fix: summarize responses is now dismisseable in surveys#30254marandaneto merged 5 commits intomasterfrom
marandaneto merged 5 commits intomasterfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Added dismissible functionality to the AI consent popover in survey components and introduced new survey response UDFs with version 5 implementations.
- Added
onDismissandonAcceptcallback props toAIConsentPopoverWrapperfor better control over popover visibility - Fixed typo "identyifying" to "identifying" in AI consent message in
/frontend/src/scenes/settings/organization/AIConsentPopoverWrapper.tsx - Added new
get_survey_response_v5UDF with support for both old (array of strings) and new (array of dictionaries) survey formats - Added comprehensive test coverage in
test_get_survey_response.pyfor the new survey response UDF - Removed duplicate
num_stepsargument inaggregate_funnel_trends_v4function definition
9 file(s) reviewed, 9 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/scenes/settings/organization/AIConsentPopoverWrapper.tsx
Outdated
Show resolved
Hide resolved
lucasheriques
changed the title
lucasheriques
changed the title
lucasheriques
force-pushed
the
fix/summarize-responses-dismisseable-popover
branch
from
a904599 to
22c6fa0
Compare
Contributor
|
Size Change: -40 B (0%) Total Size: 9.75 MB ℹ️ View Unchanged
|
marandaneto
reviewed
Mar 21, 2025
| for data analysis, | ||
| <br /> | ||
| so that you can focus on building. This <em>can</em> include | ||
| so that you can focus on building. This <em>can</em> include |
Member
There was a problem hiding this comment.
not sure i follow what the changes here are
marandaneto
approved these changes
Mar 21, 2025
…per.tsx Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Contributor
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
can't really dismiss the AI settings toggle inside surveys
Changes
adds optional properties for the
AIConsentPopoverWrapperto make it dismisseable👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
yes
How did you test this code?
smoke tests