feat(custom-columns): add guard popup for custom columns#30256
feat(custom-columns): add guard popup for custom columns#30256
Conversation
There was a problem hiding this comment.
PR Summary
Added guard popup functionality for column customization as an Enterprise Edition feature, restricting access for non-EE users with an upgrade modal.
- Added
CUSTOMIZE_COLUMNStoAvailableFeatureenum intypes.tsto mark feature as enterprise-only - Integrated
upgradeModalLogicandguardAvailableFeatureinColumnConfigurator.tsxto handle access control - Added restriction check when saving custom columns as default with
toggleSaveAsDefault - Implemented similar UX pattern as existing color customization feature for consistency
2 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| bordered | ||
| checked={saveAsDefault} | ||
| onChange={toggleSaveAsDefault} | ||
| onChange={() => guardAvailableFeature(AvailableFeature.CUSTOMIZE_COLUMNS, toggleSaveAsDefault)} |
There was a problem hiding this comment.
logic: The guard is only applied to saving default columns, but not to the initial column customization. Consider guarding the showModal action as well.
|
Size Change: +10 B (0%) Total Size: 9.75 MB ℹ️ View Unchanged
|
|
This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the |
|
This PR was closed due to lack of activity. Feel free to reopen if it's still relevant. |
Problem
the column customization is ee only feature, causing this for non-ee (self-hosted) users.

Changes
add a popup guard similar to color customization (but currently doesn't work for my local customer)
how it will look in future (for color one as example):

👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?