Merged
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Implemented profile bubbles in the user groups view to display member avatars, replacing the previous text-based member display with a more visual representation.
- Added
ProfileBubblescomponent in/frontend/src/scenes/settings/environment/UserGroups.tsxto display member avatars with tooltips - Implemented member mapping to transform user data into
ProfileBubblesformat with email, name, and title - Added expandable row functionality to show detailed member information when clicking on a group
- Included fallback "No members" text for empty groups
1 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+41
to
+45
| people={members.map((user) => ({ | ||
| email: user.email, | ||
| name: user.first_name, | ||
| title: `${user.first_name} <${user.email}>`, | ||
| }))} |
Contributor
There was a problem hiding this comment.
style: Consider adding a fallback for last_name when first_name is not available. Currently only using first_name could lead to ambiguous identification.
| title: 'Team', | ||
| dataIndex: 'name', | ||
| key: 'name', | ||
| width: 0, |
Contributor
There was a problem hiding this comment.
style: Setting width to 0 may cause layout issues. Consider using a minimum width or flex-basis instead.
Contributor
|
Size Change: -38 B (0%) Total Size: 9.75 MB ℹ️ View Unchanged
|
oliverb123
approved these changes
Mar 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Originally suggested https://posthog.slack.com/archives/C07AA937K9A/p1742398857325619
Changes