Skip to content

fix: pr-deploy name#30266

Merged
danielxnj merged 1 commit intomasterfrom
danielj/fix-pr-deploy
Mar 21, 2025
Merged

fix: pr-deploy name#30266
danielxnj merged 1 commit intomasterfrom
danielj/fix-pr-deploy

Conversation

@danielxnj
Copy link
Contributor

@danielxnj danielxnj commented Mar 21, 2025

Problem

The file pr-deploy.yaml was renamed but was not updated in the workflow that calls it.

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

@posthog-bot
Copy link
Contributor

Hey @danielxnj! 👋
This pull request seems to contain no description. Please add useful context, rationale, and/or any other information that will help make sense of this change now and in the distant Mars-based future.

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR updates the deployment workflow reference in container-images-ci.yml to use the correct filename 'pr-preview-deploy.yml', aligning with the actual workflow file in the repository.

  • Modified .github/workflows/container-images-ci.yml to reference the correct workflow file name for preview deployments
  • Maintains existing functionality and conditions for deployment based on 'deploy' label

💡 (3/5) Reply to the bot's comments like "Can you suggest a fix for this @greptileai?" or ask follow-up questions!

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

@danielxnj danielxnj merged commit b0d8df4 into master Mar 21, 2025
96 checks passed
@danielxnj danielxnj deleted the danielj/fix-pr-deploy branch March 21, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants