feat(cdp): warn about event drop when returning null or undefined#30268
Merged
meikelmosby merged 4 commits intomasterfrom Mar 24, 2025
Merged
feat(cdp): warn about event drop when returning null or undefined#30268meikelmosby merged 4 commits intomasterfrom
meikelmosby merged 4 commits intomasterfrom
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
PR Summary
Added functionality to warn users when Hog transformation functions might inadvertently drop events by returning null or undefined values, helping prevent data loss in the CDP pipeline.
- Added
mightDropEventshelper function in/frontend/src/scenes/pipeline/hogfunctions/HogFunctionConfiguration.tsxto detect potential null/undefined returns - Implemented warning display via LemonBanner when editing transformation functions that could drop events
- Enhanced detection to catch both direct null/undefined returns and indirect returns through variable assignments
1 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
frontend/src/scenes/pipeline/hogfunctions/HogFunctionConfiguration.tsx
Outdated
Show resolved
Hide resolved
Contributor
|
Size Change: +3 B (0%) Total Size: 9.75 MB ℹ️ View Unchanged
|
benjackwhite
previously requested changes
Mar 21, 2025
frontend/src/scenes/pipeline/hogfunctions/HogFunctionConfiguration.tsx
Outdated
Show resolved
Hide resolved
…out-event-drop # Conflicts: # frontend/src/scenes/pipeline/hogfunctions/HogFunctionConfiguration.tsx # frontend/src/scenes/pipeline/hogfunctions/hogFunctionConfigurationLogic.tsx
MarconLP
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Soon we release custom hog transformations and people need to be aware that if they return null or undefined that this will lead to event dropping.
Changes
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?