feat: search saved filters #32610
feat: search saved filters #32610
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds search functionality to session recording saved filters and improves empty state handling. The changes include a new search input field and dedicated empty state component.
- Added new
SavedFiltersEmptyStatecomponent infrontend/src/scenes/session-recordings/filters/SavedFiltersEmptyState.tsxto handle error and no-filters states - Added search input field in
frontend/src/scenes/session-recordings/filters/SavedFilters.tsxwith real-time filtering - Modified
savedSessionRecordingPlaylistsLogicto handle search state and filtering logic - Updated empty state to only show when there are no results AND no active search term
- Improved UI by always showing 'Saved filters' tab regardless of filter count
4 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
| import { savedSessionRecordingPlaylistsLogic } from '../saved-playlists/savedSessionRecordingPlaylistsLogic' | ||
|
|
||
| export function SavedFiltersEmptyState(): JSX.Element { | ||
| const playlistsLogic = savedSessionRecordingPlaylistsLogic({ tab: ReplayTabs.Playlists }) |
There was a problem hiding this comment.
logic: Using ReplayTabs.Playlists here seems incorrect since this is a filters view, not a playlists view
There was a problem hiding this comment.
I know. The next step is separation of logics.
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
|
Size Change: +156 B (0%) Total Size: 3.72 MB ℹ️ View Unchanged
|
veryayskiy
requested review from
a team,
pauldambra and
sortafreel
and removed request for
a team
| value={savedFiltersSearch} | ||
| stopPropagation={true} | ||
| /> | ||
| <LemonTable |
There was a problem hiding this comment.
should we pass loading to lemon table still?
There was a problem hiding this comment.
No, as we have states above it that do it nicer:
f (savedFiltersLoading && !savedFiltersSearch) {
return
}
if (savedFilters.results?.length === 0 && !savedFiltersSearch) {
return <SavedFiltersEmptyState />
}
| limit: PLAYLISTS_PER_PAGE, | ||
| offset: Math.max(0, (filters.page - 1) * PLAYLISTS_PER_PAGE), | ||
| order: filters.order ?? '-last_modified_at', // Sync with `sorting` selector | ||
| order: '-last_modified_at', |
There was a problem hiding this comment.
i guess filters.order is a collections thing?
pauldambra
left a comment
pauldambra
left a comment
There was a problem hiding this comment.
couple of questions but otherwise 
before
after