feat(ux): Feature flags scene icon and tab icon represent active state#40376
Merged
adamleithp merged 3 commits intomasterfrom Oct 28, 2025
Merged
Conversation
Contributor
|
Hey @adamleithp! 👋 |
Contributor
|
Size Change: +587 B (+0.02%) Total Size: 3.33 MB ℹ️ View Unchanged
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Contributor
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
adamleithp
changed the title
adamleithp
force-pushed
the
ux/feature-flag-functional-scene-representation
branch
from
436b152 to
45e7421
Compare
Contributor
📸 UI snapshots have been updated13 snapshot changes in total. 0 added, 13 modified, 0 deleted:
Triggered by this commit. |
adamleithp
force-pushed
the
ux/feature-flag-functional-scene-representation
branch
from
1aa92ec to
3899698
Compare
adamleithp
changed the title
Contributor
📸 UI snapshots have been updated13 snapshot changes in total. 0 added, 13 modified, 0 deleted:
Triggered by this commit. |
adamleithp
force-pushed
the
ux/feature-flag-functional-scene-representation
branch
from
dc99de3 to
513b8ab
Compare
adamleithp
commented
Oct 27, 2025
Contributor
📸 UI snapshots have been updated13 snapshot changes in total. 0 added, 13 modified, 0 deleted:
Triggered by this commit. |
adamleithp
force-pushed
the
ux/feature-flag-functional-scene-representation
branch
2 times, most recently
from
0b7788e to
c8ffac2
Compare
small updates and comments remove fancy jsx rendering, go for custom icon if flag is off revert some files, build schema remove lemon switch from scene title section, not necessary will just use new IconToggleOff for now add icon to categories, fix mt
adamleithp
force-pushed
the
ux/feature-flag-functional-scene-representation
branch
from
c8ffac2 to
ccb573f
Compare
Contributor
📸 UI snapshots have been updated11 snapshot changes in total. 0 added, 11 modified, 0 deleted:
Triggered by this commit. |
adamleithp
deleted the
ux/feature-flag-functional-scene-representation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Darkmode switch background is same as scene background, which makes it hard to see.
Changes
Replace the feature flag icon forDecided against using the jsx switch in the title area as it's distracting... if ever devs want to make it functional, go for it.. no feeling it right now.<SceneTitleSection>and with an actual<LemonSwitch>and pass inchecked=active<SceneTitleSection>'s and breadcrumbsiconTypewith new<IconToggleOff />when FF is not active<LemonSwitch />background to be more visible in darkmode (Was gray-900, and the background in darkmodeHow did you test this code?
Locally