-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs: shared onboarding for web analytics #46197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Size Change: 0 B Total Size: 86.5 MB ℹ️ View Unchanged
|
rafaeelaudibert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, but remove the change to WorkflowsTable and also check with @lricoy whether the mobile suggestion makes sense
| export const MobileFinalSteps = (): JSX.Element => { | ||
| const { Markdown } = useMDXComponents() | ||
|
|
||
| return ( | ||
| <> | ||
| <Markdown> | ||
| Despite the name, the web analytics dashboard can be used to track screen views in mobile apps, too. | ||
| Open your app and view some screens to generate some events. | ||
| </Markdown> | ||
| </> | ||
| ) | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // We can't just reset state within the logic's unmount as that would trigger when switching tabs | ||
| const newWorkflowLogic = workflowLogic.findMounted({ id: 'new', tabId: props.tabId }) | ||
| newWorkflowLogic?.unmount() | ||
| }, []) | ||
| }, [props.tabId]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Re: lines +102 to +107]
Don't change this. I know it was automatic, but please revert
See this comment inline on Graphite.
|
Docs from this PR will be published at posthog.com
Preview will be ready in ~10 minutes. Click Preview link above to access docs at |
Visual regression: Playwright E2E E2E screenshots updatedChanges: 2 snapshots (2 modified, 0 added, 0 deleted) What this means:
Next steps:
|
migrates web analytics to shared onboarding docs architecture:
docs/onboarding/web-analyticscreatedPublish to changelog?
no