fix(tasks): Simplify repository selector to reuse existing components#52141
Open
Twixes wants to merge 1 commit intosignals/report-generation-agentfrom
Open
fix(tasks): Simplify repository selector to reuse existing components#52141Twixes wants to merge 1 commit intosignals/report-generation-agentfrom
Twixes wants to merge 1 commit intosignals/report-generation-agentfrom
Conversation
Replace custom repositorySelectorLogic and manual GitHub integration UI with existing IntegrationChoice and GitHubRepositoryPicker components. Simplify RepositoryConfig to use owner/repo format directly.
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
|
Size Change: -174 B (0%) Total Size: 110 MB ℹ️ View Unchanged
|
Contributor
🔍 Migration Risk AnalysisWe've analyzed your migrations for potential risks. Summary: 1 Safe | 2 Needs Review | 0 Blocked
|
Twixes
changed the title
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: products/tasks/backend/services/connection_token.py
Line: 30
Comment:
**Inconsistent setting access pattern with `create_sandbox_connection_token`**
`get_sandbox_jwt_public_key` was changed to use direct attribute access (`settings.SANDBOX_JWT_PRIVATE_KEY`), but `create_sandbox_connection_token` at line 57 still uses `getattr(settings, "SANDBOX_JWT_PRIVATE_KEY", None)`. This inconsistency is worth resolving.
If `SANDBOX_JWT_PRIVATE_KEY` is not defined at all in the Django settings module (not just empty/falsy), the direct access will raise `AttributeError` while the `getattr` pattern will fall through to the descriptive `ValueError`. Both functions should use the same pattern.
Either update `create_sandbox_connection_token` to also use direct access:
```suggestion
private_key_pem = settings.SANDBOX_JWT_PRIVATE_KEY
```
Or revert this change to keep both functions consistent with `getattr`.
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "fix(tasks): simplify repository selector..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
jonathanlab
approved these changes
Mar 27, 2026
Contributor
jonathanlab
left a comment
jonathanlab
left a comment
There was a problem hiding this comment.
nice :) ran it locally and works as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The repository selector in Tasks had its own custom
repositorySelectorLogicreimplementing GitHub integration/repo picking from scratch, when we already haveIntegrationChoiceandGitHubRepositoryPickercomponents that do this better!Changes
Replaced the custom
repositorySelectorLogickea logic with existingIntegrationChoiceandGitHubRepositoryPicker. SimplifiedRepositoryConfigto useowner/repoformat directly (dropped separateorganizationfield).How did you test this code?
Ran it.
Publish to changelog?
No